r3 - 23 Jul 2007 - 18:06:52 - BobbyRulloYou are here: OSAF > Journal Web > BobbyRulloNotes > UiCodeIssues
ContentBox
- mde's layout system with its ContentBox? etc. seems to me redundant - it's another widget system.
- doesn't keep a handle on the widgets, just the widget dom nodes (see for example layout.js handling of CollectionSelector?)
- fillInTemplate is a nightmare. WAY too long, too many functions defined inside that function
- uses closures like global variables with short names. Hard to find where they where set. Difficult to refactor because of all the closures. Bad encapsulation
- don't really like passing the error as an arg...unless using kwArgs...something icky, can't place finger on what.
Log In
Except where otherwise noted, this site and its content are licensed by OSAF under an Creative Commons License, Attribution Only 3.0.
See list of page contributors for attributions.
See list of page contributors for attributions.