EditAttachWiki Help
r3 - 02 Jan 2008 - 12:13:50 - BobbyRulloYou are here: OSAF >  Journal Web  >  TWikiUsers > BobbyRullo > BobbyRulloLeftBar > CodeReview
  • cosmo.account.preferences has an unnatural dependency on cosmo.app.pim. Why bring in the whole PIM to deal w/ prefs? Makes testing quite difficult. Look into de-coupling.
  • cosmo.app.pim.loadCollections() color stuff: a) Magic numbers are bad b) do we need this?
  • cosmo.util.html.createInput - needs more doco, some kwArgs not in example, like "checked"
Edit | WYSIWYG | Attach | Printable | Raw View | Backlinks: Web, All Webs | History: r3 < r2 < r1 | More topic actions
 
Open Source Applications Foundation
Except where otherwise noted, this site and its content are licensed by OSAF under an Creative Commons License, Attribution Only 3.0.
See list of page contributors for attributions.